[webkit-reviews] review granted: [Bug 115567] check-webkit-style should complain about a layering violation if platform-specific guards are used in WebCore outside of the platform directory : [Attachment 200459] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 3 16:12:34 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 115567: check-webkit-style should complain about a layering violation if
platform-specific guards are used in WebCore outside of the platform directory
https://bugs.webkit.org/show_bug.cgi?id=115567
Attachment 200459: Patch
https://bugs.webkit.org/attachment.cgi?id=200459&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Awesome idea!
I would have a couple more tests for:
-various spacing
-ifdef in a comment.
More information about the webkit-reviews
mailing list