[webkit-reviews] review requested: [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX : [Attachment 200414] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 07:53:24 PDT 2013


Sergio Correia <sergio.correia at openbossa.org> has asked  for review:
Bug 105156: [EFL] Process launcher uses system() for wrapping the WebProcess
when using WEB_PROCESS_CMD_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=105156

Attachment 200414: Patch
https://bugs.webkit.org/attachment.cgi?id=200414&action=review

------- Additional Comments from Sergio Correia <sergio.correia at openbossa.org>
Addressing Mikhail's comments: 1) fixed bug title; 2) not composing/decomposing
command string; now we decompose the prefix only, and have the other parameters
passed as different arguments; 3) not keeping another Vector<String>; now we
copy the strings to m_argv with strdup and release them with free in the
destructor.


More information about the webkit-reviews mailing list