[webkit-reviews] review denied: [Bug 115516] Remove WTF::ListRefPtr class : [Attachment 200392] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 115516: Remove WTF::ListRefPtr class
https://bugs.webkit.org/show_bug.cgi?id=115516

Attachment 200392: patch
https://bugs.webkit.org/attachment.cgi?id=200392&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200392&action=review


No need to update the order files, they're re-generated by someone in the
WebKit performance team every once in a while.

> Source/WebCore/platform/graphics/FontFamily.h:74
> +    RefPtr<SharedFontFamily> reaper = m_next.release();
> +    while (reaper && reaper->hasOneRef())
> +	   reaper = reaper->releaseNext(); // implicitly protects reaper->next,
then derefs reaper

I'd add a comment stating that this initially came from ListRefPtr and that it
can probably be a regular RefPtr.