[webkit-reviews] review granted: [Bug 115526] Shadow DOM removal: Make SelectorChecker non-generic : [Attachment 200335] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 115526: Shadow DOM removal: Make SelectorChecker non-generic
https://bugs.webkit.org/show_bug.cgi?id=115526

Attachment 200335: patch
https://bugs.webkit.org/attachment.cgi?id=200335&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200335&action=review


r=me

> Source/WebCore/css/SelectorChecker.cpp:65
> +static inline bool isFirstChildElement(Element* element)

I'd make this take a const Element*.

> Source/WebCore/css/SelectorChecker.cpp:70
> +static inline bool isLastChildElement(Element* element)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:75
> +static inline bool isFirstOfType(Element* element, const QualifiedName&
type)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:84
> +static inline bool isLastOfType(Element* element, const QualifiedName& type)


Ditto.

> Source/WebCore/css/SelectorChecker.cpp:93
> +static inline int countElementsBefore(Element* element)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:107
> +static inline int countElementsOfTypeBefore(Element* element, const
QualifiedName& type)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:117
> +static inline int countElementsAfter(Element* element)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:125
> +static inline int countElementsOfTypeAfter(Element* element, const
QualifiedName& type)

Ditto.

> Source/WebCore/css/SiblingTraversalStrategies.h:1
> +// Remove this file.

wat