[webkit-reviews] review granted: [Bug 115520] [WK2] Non-ASCII downloaded file names are garbled when using NetworkProcess : [Attachment 200325] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 115520: [WK2] Non-ASCII downloaded file names are garbled when using
NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=115520

Attachment 200325: proposed fix
https://bugs.webkit.org/attachment.cgi?id=200325&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200325&action=review


> Source/WebCore/platform/network/ResourceRequestBase.h:114
> +	   const Vector<String>
responseContentDispositionEncodingFallbackArray() const { return
m_responseContentDispositionEncodingFallbackArray; }

The const here in const Vector<String> is not needed or helpful. Unless maybe
you wanted to return const& to avoid copying.

> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:63
> +    encoder <<
resourceRequest.responseContentDispositionEncodingFallbackArray();

Do we have to bump a version number when we do things like this?