[webkit-reviews] review granted: [Bug 115432] REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align : [Attachment 200142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 2 11:21:41 PDT 2013


Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 115432: REGRESSION(r140907): Incorrect baseline on cells after updating
vertical-align
https://bugs.webkit.org/show_bug.cgi?id=115432

Attachment 200142: Patch
https://bugs.webkit.org/attachment.cgi?id=200142&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200142&action=review


> Source/WebCore/rendering/RenderTableCell.cpp:408
> +    if (oldStyle && style()->verticalAlign() != oldStyle->verticalAlign())

Let's add a comment about why this is required.


More information about the webkit-reviews mailing list