[webkit-reviews] review granted: [Bug 115505] REGRESSION (r149422): -[WKBrowsingContextController loadFileURL:restrictToFilesWithin:] broken when second argument is nil : [Attachment 200301] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 115505: REGRESSION (r149422): -[WKBrowsingContextController
loadFileURL:restrictToFilesWithin:] broken when second argument is nil
https://bugs.webkit.org/show_bug.cgi?id=115505

Attachment 200301: proposed fix
https://bugs.webkit.org/attachment.cgi?id=200301&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200301&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:744
>      if (!resourceDirectoryURLString.isNull()) {

I would put the null case first since it’s shorter, and then the non-null case.


> Source/WebKit2/UIProcess/WebPageProxy.cpp:749
> +	   resourceDirectoryURL = KURL(ParsedURLString, "file:///");

Should be KURL(ParsedURLString, ASCIILiteral("file:///")).