[webkit-reviews] review granted: [Bug 111513] Create a script to import W3C tests : [Attachment 200295] Incorporated Dirk's feedback

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Rebecca Hauck
<rhauck at adobe.com>'s request for review:
Bug 111513: Create a script to import W3C tests
https://bugs.webkit.org/show_bug.cgi?id=111513

Attachment 200295: Incorporated Dirk's feedback
https://bugs.webkit.org/attachment.cgi?id=200295&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200295&action=review


Looks pretty good, so I'm R+'ing it with a few more nits. Feel free to fix
those and land w/o another review. Once we do that, if you want to use this
script to import specific subdirs I think that's great but we should probably
do so on an ad-hoc basis into someplace *other* than where we might want the
long-term location of the whole w3 repo to be.

In other words, if we end up wanting to put the w3c's tests in
LayoutTests/w3c/... , don't import submitted/adobe/regions (or whatever) into
LayoutTests/w3c/submitted/adobe/regions directly. You should probably have me
review the first import or two just to see how it goes.

Thanks so much for working on this!

> Tools/Scripts/import-w3c-tests:3
> +# Copyright (C) 2010 Apple Inc. All rights reserved.

copyright :)

> Tools/Scripts/webkitpy/w3c/test_converter.py:31
> +from webkitpy.thirdparty.BeautifulSoup import Tag

nit: list the standard modules first, then the stuff from webkitpy.thirdparty.
Also, you can (and should) do "import BeautifulSoup, Tag"

> Tools/Scripts/webkitpy/w3c/test_converter.py:47
> +

nit: don't put a blank line here.

> Tools/Scripts/webkitpy/w3c/test_importer.py:109
> +

nit: don't put blank lines between your method declarations and the body of the
methods.