[webkit-reviews] review granted: [Bug 115391] [webkitpy] Need abstract base class for commands that analyze commit logs : [Attachment 200202] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Glenn Adams
<glenn at skynav.com>'s request for review:
Bug 115391: [webkitpy] Need abstract base class for commands that analyze
commit logs
https://bugs.webkit.org/show_bug.cgi?id=115391

Attachment 200202: Patch
https://bugs.webkit.org/attachment.cgi?id=200202&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200202&action=review


> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:62
> +	   options = sorted(options, lambda a, b: cmp(a._long_opts,
b._long_opts))

I would prefer named arguments with sorted().