[webkit-reviews] review granted: [Bug 115463] [Mac] WebKit doesn't enable or disable autocorrections when system preferences are changed : [Attachment 200256] Updated per Sam's comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 115463: [Mac] WebKit doesn't enable or disable autocorrections when system
preferences are changed
https://bugs.webkit.org/show_bug.cgi?id=115463

Attachment 200256: Updated per Sam's comments
https://bugs.webkit.org/attachment.cgi?id=200256&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200256&action=review


> Source/WebKit2/ChangeLog:13
> +	   (WebKit):
> +	   (TextChecker):

Should remove these, or fix the script so they don’t get added in the first
place.

> Source/WebKit2/ChangeLog:15
> +	   (WebContext):

Ditto.

> Source/WebKit2/ChangeLog:18
> +	   (WebKit):

Ditto.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:555
> +    [[NSNotificationCenter defaultCenter]
removeObserver:(id)m_automaticTextReplacementNotificationObserver.get()];

Can’t these be RetainPtr<NSObject> instead of RetainPtr<CFTypeRef>, to avoid
all these (id) casts?