[webkit-reviews] review denied: [Bug 115495] Web Inspector: Fix check-inspector-strings script and fix localized strings : [Attachment 200251] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 1 16:40:42 PDT 2013
Joseph Pecoraro <joepeck at webkit.org> has denied Seokju Kwon
<seokju.kwon at gmail.com>'s request for review:
Bug 115495: Web Inspector: Fix check-inspector-strings script and fix localized
strings
https://bugs.webkit.org/show_bug.cgi?id=115495
Attachment 200251: Patch
https://bugs.webkit.org/attachment.cgi?id=200251&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200251&action=review
The update to the tool seems good. But seems like some issues with the updated
strings file.
> Source/WebCore/English.lproj/localizedStrings.js:-623
> -localizedStrings["Filter"] = "Filter";
I still see this in ConsoleView.js. Was this a duplicate entry?
ConsoleView.js
468: var filterSubMenu =
contextMenu.appendSubMenuItem(WebInspector.UIString("Filter"));
> Source/WebCore/English.lproj/localizedStrings.js:936
> +localizedStrings["Number of calls"] = "Self time";
This doesn't look right. "Number of calls" should be "Number of calls".
More information about the webkit-reviews
mailing list