[webkit-reviews] review requested: [Bug 115498] Null check plugInClient earlier in snapshotting path : [Attachment 200252] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 115498: Null check plugInClient earlier in snapshotting path
https://bugs.webkit.org/show_bug.cgi?id=115498

Attachment 200252: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=200252&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I'm not very familiar with this path, but this crash certainly seems possible
(a port that doesn't set a plugin in client but has snapshotting enabled
because the Setting is enabled by default). We should be resilient in such
cases and not crash. Maybe it makes sense to ASSERT at some other point that a
plugin client is set.