[webkit-reviews] review granted: [Bug 115468] fourthTier: Structure::addPropertyTransitionToExistingStructure should be thread-safe : [Attachment 200242] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 115468: fourthTier: Structure::addPropertyTransitionToExistingStructure
should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115468

Attachment 200242: the patch
https://bugs.webkit.org/attachment.cgi?id=200242&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200242&action=review


> Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:204
> +    Structure* transition =
Structure::addPropertyTransitionToExistingStructureConcurrently(structure,
ident, 0, 0, offset);

This function could use a better name that doesn't imply that it performs an
add.