[webkit-reviews] review granted: [Bug 115455] [CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled : [Attachment 200218] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 115455: [CSS Exclusions] Programmatic layout tests fail when subpixel
layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115455

Attachment 200218: Patch
https://bugs.webkit.org/attachment.cgi?id=200218&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200218&action=review


>>>
LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-layout.html:61
>>> +  shouldBe("shapeInsideRect('d').top", String(lineATop + 45), quiet);
>> 
>> Why are they passing quietly?
> 
> Yes, that's why I used the quiet parameter. I didn't use shouldBeCloseTo(),
since it's for checking if a value is within a tolerance and its PASSED message
reports the expected value.  Specifying a non-zero tolerance would work in
these cases, but that would be a weaker test.

As long as we don't possibly get a wrong positive, it is fine with me. r=me.