[webkit-reviews] review granted: [Bug 115483] [WK2][Mac] Pass plug-in bundle ID to LaunchServices : [Attachment 200230] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 115483: [WK2][Mac] Pass plug-in bundle ID to LaunchServices
https://bugs.webkit.org/show_bug.cgi?id=115483

Attachment 200230: proposed patch
https://bugs.webkit.org/attachment.cgi?id=200230&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200230&action=review


> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:47
> +const CFStringRef _kLSPluginBundleIdentifierKey =
CFSTR("LSPluginBundleIdentifierKey");

Why the underscore? Don’t we need “static” on this to prevent it from having
external linkage?

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:285
> +static String loadSandboxProfileForDirectory(String bundleIdentifier,
NSString *sandboxProfileDirectoryPath)

Why the change from const String& to String for the argument type? Please use
const String&.