[webkit-reviews] review requested: [Bug 115455] [CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled : [Attachment 200218] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 1 11:26:00 PDT 2013


Hans Muller <giles_joplin at yahoo.com> has asked	for review:
Bug 115455: [CSS Exclusions] Programmatic layout tests fail when subpixel
layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115455

Attachment 200218: Patch
https://bugs.webkit.org/attachment.cgi?id=200218&action=review

------- Additional Comments from Hans Muller <giles_joplin at yahoo.com>
Last week on Friday, WebKit disabled subpixel layout for Mac, and 13 of the
exclusions tests failed.  This turned out to be a bit of blessing in disguise,
it exposed some implementation and test problems.  

This is the first patch of likely 2 or 3.  It restores 4 tests that were
failing, and one that wasn't:

fast/exclusions/shape-inside/shape-inside-polygon-layout.html 
fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html
fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygo
n.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.h
tml

fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html


More information about the webkit-reviews mailing list