[webkit-reviews] review granted: [Bug 113662] Regions should be allocated from the same contiguous segment of virtual memory : [Attachment 195922] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 113662: Regions should be allocated from the same contiguous segment of
virtual memory
https://bugs.webkit.org/show_bug.cgi?id=113662

Attachment 195922: Patch
https://bugs.webkit.org/attachment.cgi?id=195922&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195922&action=review


Other than the one comment, looks good!

> Source/WTF/wtf/MetaAllocator.h:67
> +    WTF_EXPORT_PRIVATE MetaAllocator(size_t allocationGranule, size_t
pageSize = 0);

Why not say pageSize = WTF::pageSize() and then get rid of the pageSize
initialization conditional inside MetaAllocator::MetaAllocator?