[webkit-reviews] review granted: [Bug 113494] [EFL] Enable user-select:all for EFL port : [Attachment 195673] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 31 18:36:52 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 113494: [EFL] Enable user-select:all for EFL port
https://bugs.webkit.org/show_bug.cgi?id=113494

Attachment 195673: Patch
https://bugs.webkit.org/attachment.cgi?id=195673&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review


LGTM.

>>> LayoutTests/platform/efl/TestExpectations:-1535
>>> -webkit.org/b/100424 editing/selection/user-select-all-selection.html [
Failure ]
>> 
>> Don't you need to rebaseline this test case ? When I run this test with your
patch, this test was failed.
> 
> When I tested the case in my local, it has passed. I have double checked in
other PC, too. Could you let me know how tested the case?

Hmm, there was something wrong. This test is passed on my pc now. Sorry for
noise.


More information about the webkit-reviews mailing list