[webkit-reviews] review granted: [Bug 87806] Add mouse support to pointer and hover CSS media features : [Attachment 194596] Review Fixes

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted David Bokan <bokan at chromium.org>'s
request for review:
Bug 87806: Add mouse support to pointer and hover CSS media features
https://bugs.webkit.org/show_bug.cgi?id=87806

Attachment 194596: Review Fixes
https://bugs.webkit.org/attachment.cgi?id=194596&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194596&action=review


This seems like a reaonable improvement over what we've got currently, but we
seem to be missing a notification pathway for when the primary device changes.

> Source/WebCore/ChangeLog:6
> +	   Reviewed by Adam Barth

You should leave this line as the default (i.e., saying "nobody").  The tools
will fill in the correct value automatically based on who actually sets the
review flag to +.

> Source/WebCore/page/Settings.h:64
> +    // Enum for primary pointer device to tell WebKit what kind of input the

> +    // user is primarily using. Note that it's not an indication of what's 
> +    // available on the user's system.
> +    // e.g. Primary pointer may be set to PointerDeviceMouse but device has
> +    // a mouse and a touch screen.

How do we know what the primary input device is?  Is there a notification
pathway if that changes (e.g., a laptop that transforms into a tablet)?