[webkit-reviews] review granted: [Bug 110835] [Chromium] Implement target-densityDpi viewport property emulation : [Attachment 195547] Move parsing code to ViewportArguments

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted  review:
Bug 110835: [Chromium] Implement target-densityDpi viewport property emulation
https://bugs.webkit.org/show_bug.cgi?id=110835

Attachment 195547: Move parsing code to ViewportArguments
https://bugs.webkit.org/attachment.cgi?id=195547&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195547&action=review


Ok, I'm convinced about this approach.	It's nice that it's not much code. 
However, if the implementation starts spidering throughout the codebase like
the old implementation, we might want to reconsider.

> Source/WebCore/dom/ViewportArguments.h:96
> +	   , deprecatedTargetDensityDpi(ValueAuto)

Dpi -> DPI

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:662
> +    if (m_webView->settingsImpl()->supportDeprecatedTargetDensityDpi()) {

Dpi -> DPI