[webkit-reviews] review granted: [Bug 113656] fourthTier: FTL JIT should supply TBAA meta-data to LLVM : [Attachment 195900] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 113656: fourthTier: FTL JIT should supply TBAA meta-data to LLVM
https://bugs.webkit.org/show_bug.cgi?id=113656

Attachment 195900: the patch
https://bugs.webkit.org/attachment.cgi?id=195900&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195900&action=review


> Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:117
> +	   

static const char* negSplit = "_neg_";

> Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:118
> +	   size_t stringLength = m_heapNameLength + (negative ? 5 : 1) +
numHexlets;

negative ? sizeof(negSplit) : 1

> Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:124
> +	       memcpy(characters + m_heapNameLength, "_neg_", 5);

memcpy(characters + m_heapNameLength, negSplit, sizeof(negSplit))

feel free to choose a better name than negsplit though :D

> Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:130
> +	       characters[stringLength - i - 1] =
("0123456789ABCDEF")[accumulator & 0xF];

Slightly concerned about this leaking address space layout info, but this would
be trivial to fix if it were a problem, and i'm not sure if it is a problem
without some bug already being present.