[webkit-reviews] review granted: [Bug 113651] Use Vector::reserveInitialCapacity and Vector::uncheckedAppend for JSC's APIs : [Attachment 195885] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 113651: Use Vector::reserveInitialCapacity and Vector::uncheckedAppend for
JSC's APIs
https://bugs.webkit.org/show_bug.cgi?id=113651

Attachment 195885: Patch
https://bugs.webkit.org/attachment.cgi?id=195885&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195885&action=review


Sure, r=me.

> Source/JavaScriptCore/API/JSCallbackConstructor.cpp:79
> +	   for (size_t i = 0; i < argumentCount; i++)

If I was driving by in this neighborhood, I'd change the i++ to ++i because
reasons.

> Source/JavaScriptCore/API/JSCallbackFunction.cpp:75
> +    for (size_t i = 0; i < argumentCount; i++)

And here.

> Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:374
> +	       for (size_t i = 0; i < argumentCount; i++)

Probably also here.

> Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:441
> +	       for (size_t i = 0; i < argumentCount; i++)

Not sure about here. Well, yeah okay here too.