[webkit-reviews] review denied: [Bug 113331] Web Inspector: Encapsulate SetEmbedderData/GetEmbedderData : [Attachment 195137] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 113331: Web Inspector: Encapsulate SetEmbedderData/GetEmbedderData
https://bugs.webkit.org/show_bug.cgi?id=113331

Attachment 195137: Patch
https://bugs.webkit.org/attachment.cgi?id=195137&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195137&action=review


> Source/WebCore/bindings/v8/V8PerContextData.cpp:175
> +	       wanted = snprintf(buffer, sizeof(buffer), "%s", worldName);

So you formatted the format above, but you don't actually need it here? Why
formatting the format at all then? I.e. 
if (debugId == -1)
    snprintf(buffer, sizeof(buffer), "%s", worldName);
else
    snprintf(buffer, sizeof(buffer), "%s,%d", worldName, debugId);

sounds simpler.

> Source/WebCore/bindings/v8/V8PerContextData.cpp:185
> +v8::Handle<v8::Value>
V8PerContextDebugData::getDebugData(v8::Handle<v8::Context> context)

No get prefixes in WebKit, simply debugData()