[webkit-reviews] review granted: [Bug 113616] Crash when "willSendRequest" causes the ResourceLoader to be cancelled. : [Attachment 195811] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 113616: Crash when "willSendRequest" causes the ResourceLoader to be
cancelled.
https://bugs.webkit.org/show_bug.cgi?id=113616

Attachment 195811: Patch v1
https://bugs.webkit.org/attachment.cgi?id=195811&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195811&action=review


> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:161
> +    ASSERT(loader);
> +    if (!loader)
> +	   return;

How strongly do you feel about this? We usually do not not add such checks
without knowing that this actually happens, and waiting for reproducible cases.