[webkit-reviews] review granted: [Bug 113613] Expose FeatureObserver data to WebKit clients : [Attachment 195810] proposed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 113613: Expose FeatureObserver data to WebKit clients
https://bugs.webkit.org/show_bug.cgi?id=113613

Attachment 195810: proposed patch
https://bugs.webkit.org/attachment.cgi?id=195810&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195810&action=review


> Source/WebCore/loader/FrameLoader.cpp:3356
> +    info.addMember(m_previousURL, "previousUrl");

You should fix the string as well.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4007
> +    // FIXME: Feature names should not be hardcoded.

Bug number?