[webkit-reviews] review granted: [Bug 113481] fourthTier: FTL JIT should be able run some simple function : [Attachment 195806] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 113481: fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481

Attachment 195806: the patch
https://bugs.webkit.org/attachment.cgi?id=195806&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195806&action=review


Please file a bug for each fix me, and for the weak viable thingy, and for the
"use our executable allocator" thingy.

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:3671
> +			shellScript = "exit 0\n\nif [ -f
../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n   
../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";

This needs a bug report.

>> Source/JavaScriptCore/ftl/FTLCompile.cpp:57
>> +	if (LLVMCreateJITCompilerForModule(&engine, state.module, 2, &error) !=
0) {
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.  [readability/comparison_to_zero] [5]

Please fix.

>> Source/JavaScriptCore/ftl/FTLJITCode.h:33
>> +#include "JITCode.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix.