[webkit-reviews] review granted: [Bug 113438] Add LayoutTests that verify MediaSource.duration behavior. : [Attachment 195796] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 113438: Add LayoutTests that verify MediaSource.duration behavior.
https://bugs.webkit.org/show_bug.cgi?id=113438

Attachment 195796: Patch
https://bugs.webkit.org/attachment.cgi?id=195796&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195796&action=review


>>>
LayoutTests/http/tests/media/media-source/video-media-source-duration-boundaryc
onditions-expected.txt:29
>>> +EXPECTED (mediaSource.duration == 'testDurationValue'), OBSERVED
'3.4028234663852886e+38' FAIL
>> 
>> Are these failures expected? If so, this suffers from the same problem as
the previous patch: not all ports will have exactly the same duration so each
will need custom results.
> 
> Yes these are expected because HTMLMediaElement.duration is a float and
MediaSource.duration is a double. Until HTMLMediaElement.duration is updated to
a double to match the HTML5 spec, these test cases will fail. :/ These
expectations were just to capture the fact that MediaSource.duration truncates
itself to the float range so that MediaSource.duration always equals
HTMLMediaElement.duration.

Why not just fix HTMLMediaElement? Have you filed a bug about the issue?