[webkit-reviews] review granted: [Bug 113603] "Empty cache..." clears the disk cache from each WebProcess : [Attachment 195790] Patch v1

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 113603: "Empty cache..." clears the disk cache from each WebProcess
https://bugs.webkit.org/show_bug.cgi?id=113603

Attachment 195790: Patch v1
https://bugs.webkit.org/attachment.cgi?id=195790&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195790&action=review


> Source/WebKit2/NetworkProcess/NetworkProcess.h:131
> +#if PLATFORM(MAC)
> +    dispatch_group_t m_clearCacheDispatchGroup;
> +#endif

Please add a FIXME and file a bug about doing this in a way that doesn't
require an #ifdef.  e.g. Using a WorkQueue and BinarySemaphore.

> Source/WebKit2/UIProcess/WebResourceCacheManagerProxy.cpp:121
>      // FIXME (Multi-WebProcess): <rdar://problem/12239765> There is no need
to relaunch all processes. One process to take care of persistent cache is
enough.
>     
context()->sendToAllProcessesRelaunchingThemIfNecessary(Messages::WebResourceCa
cheManager::ClearCacheForAllOrigins(cachesToClear));

Do we still want to send this if we are using the network process?