[webkit-reviews] review granted: [Bug 106143] min-width/max-width of min-content/max-content don't work correctly if the width set : [Attachment 195777] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 106143: min-width/max-width of min-content/max-content don't work correctly
if the width set
https://bugs.webkit.org/show_bug.cgi?id=106143

Attachment 195777: Patch
https://bugs.webkit.org/attachment.cgi?id=195777&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195777&action=review


> Source/WebCore/ChangeLog:3
> +	   min-width/max-width of min-content/max-content don't work correctly
if the width set

"if the width set" is awkward.	Maybe "if width is specified"

> Source/WebCore/rendering/RenderBlock.cpp:5756
> +	   // FIXME: Remove this const_casts.

Nit: const_casts -> const_cast

> LayoutTests/ChangeLog:15
> +	   * platform/chromium-win/fast/table/overflowHidden-expected.txt:
> +	   The new result correctly adds the scrollbar width to the table cell
intrinsic width.

I would make a note why the pixel result isn't updated.