[webkit-reviews] review granted: [Bug 110820] IndexedDB: Bind lifetime of in-memory backing stores to IDBFactory backend : [Attachment 195760] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 110820: IndexedDB: Bind lifetime of in-memory backing stores to IDBFactory
backend
https://bugs.webkit.org/show_bug.cgi?id=110820

Attachment 195760: Patch
https://bugs.webkit.org/attachment.cgi?id=195760&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195760&action=review


> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:354
> +#if PLATFORM(CHROMIUM)
> +    ASSERT(WebKit::Platform::current()->unitTestSupport());
> +#endif

I don't understand what this assert is checking.  When is unitTestSupport()
null?

> Source/WebKit/chromium/tests/IDBBackingStoreTest.cpp:307
> +    EXPECT_EQ(memStore1->refCount(), 2);

Nit: I thought the expected values go on the left, but I guess this file gets
this wrong in other places.