[webkit-reviews] review granted: [Bug 34085] [GTK] Should use GStreamer codec installation infrastructure : [Attachment 195748] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 34085: [GTK] Should use GStreamer codec installation infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34085

Attachment 195748: Patch
https://bugs.webkit.org/attachment.cgi?id=195748&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195748&action=review


Very simple and nice! Please fix the style issues when landing.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:50

> +#include <gst/pbutils/missing-plugins.h>

Should be listed alphabetically in the list.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:782
> +	       GstInstallPluginsReturn result =
gst_install_plugins_async(&detail, 0,
mediaPlayerPrivatePluginInstallerResultFunction,
reinterpret_cast<gpointer>(this));

There's no cast necessary to go from a class pointer to void* and
reinterpret_cast here can hide real errors, so please remove the cast.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:35
> +#include <gst/pbutils/install-plugins.h>

Please list this alphabetically.