[webkit-reviews] review denied: [Bug 110921] Web Inspector: allow referencing of nodes that have not been pushed to the front-end : [Attachment 195555] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 110921: Web Inspector: allow referencing of nodes that have not been pushed
to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921

Attachment 195555: Patch
https://bugs.webkit.org/attachment.cgi?id=195555&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195555&action=review


We need to test this.

> Source/WebCore/inspector/Inspector.json:1722
> +		   "description": "Unique DOM node identifier used to reference
a node that may not have been pushed to the front-end."

"hidden": true

> Source/WebCore/inspector/InspectorDOMAgent.cpp:326
> +	   m_backendIdToNode.remove(backendId);

Thinking about the future... If we want to re-use ids after say timeline was
stopped, we might want these nodes retained. I.e. we might want to have a named
object group that will be discarded either on demand or when all its backend
ids are resolved to node ids. Just thinking out loud.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:353
> +    if (nodesMap->contains(node))

You don't need to change this.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:630
> +	   current = innerParentNode(current);

You don't need to retain parent path.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1762
> +	   *nodeId = pushNodePathToFrontend(node);

You should discard backend id at this point (clean up the map)