[webkit-reviews] review denied: [Bug 113410] Web Inspector: Flame Chart. Developers will have more clue if two different profiles will have same colors for same functions. : [Attachment 195729] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 113410: Web Inspector: Flame Chart. Developers will have more clue if two
different profiles will have same colors for same functions.
https://bugs.webkit.org/show_bug.cgi?id=113410

Attachment 195729: Patch
https://bugs.webkit.org/attachment.cgi?id=195729&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195729&action=review


> Source/WebCore/inspector/front-end/FlameChart.js:74
> +    this._colorGenerator = WebInspector.FlameChart._colorGenerator;

Why do you need local field?

> Source/WebCore/inspector/front-end/FlameChart.js:289
> +	   var colorGenerator = this._colorGenerator;

Why do you need this variable?

> Source/WebCore/inspector/front-end/FlameChart.js:348
> +	   var colorGenerator = this._colorGenerator;

ditto