[webkit-reviews] review denied: [Bug 113410] Web Inspector: Flame Chart. Developers will have more clue if two different profiles will have same colors for same functions. : [Attachment 195549] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 113410: Web Inspector: Flame Chart. Developers will have more clue if two
different profiles will have same colors for same functions.
https://bugs.webkit.org/show_bug.cgi?id=113410

Attachment 195549: Patch
https://bugs.webkit.org/attachment.cgi?id=195549&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195549&action=review


> Source/WebCore/inspector/front-end/FlameChart.js:75
> +    this._colorGenerator = panel.colorGenerator;

You can't declare properties on alien objects, just make it static!

I.e. if (!WebInspector.FlameChart._colorGenerator)