[webkit-reviews] review granted: [Bug 113359] [EFL][EGL] Add support for creating offscreen surface. : [Attachment 195636] patchv5

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 113359: [EFL][EGL] Add support for creating offscreen surface.
https://bugs.webkit.org/show_bug.cgi?id=113359

Attachment 195636: patchv5
https://bugs.webkit.org/attachment.cgi?id=195636&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195636&action=review


> Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:100
> +    configs = new EGLConfig[numConfigs];

Nit: this can be EGLConfig configs[numConfigs]; and then you don't need to
explicitly call delete.

> Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.h:49
> +    EGLConfig createConfig(EGLint);

EGLint expectedSurfaceType

> Source/WebCore/platform/graphics/surfaces/egl/EGLHelper.cpp:53
> +	   if (success != EGL_TRUE) {
> +	       LOG_ERROR("EGLInitialization failed.");
> +	       m_eglDisplay = EGL_NO_DISPLAY;
> +	   }

Shouldn't you return early here?

> Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.cpp:80
> +    if (!eglBindAPI(eglAPIVersion)) {
> +	   LOG_ERROR("Failed to set EGL API(%d).", eglGetError());

Why would you need to set the API version on destruction?