[webkit-reviews] review granted: [Bug 113547] Compiler warning in IDBTransaction::modeToString : [Attachment 195683] Fix compiler warning

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 113547: Compiler warning in IDBTransaction::modeToString
https://bugs.webkit.org/show_bug.cgi?id=113547

Attachment 195683: Fix compiler warning
https://bugs.webkit.org/attachment.cgi?id=195683&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This looks like a good change to me. Normally, this is our preferred style for
switches on enums. We like to leave out the default case from the switch so
that some compilers (gcc family ones) can warn if we fail to include one of the
enum values. And we like to have an ASSERT_NOT_REACHED after the switch so that
we get predictable behavior in release builds, and an assertion in debug
builds, if we have a bizarre value at runtime that is not one of the enum
values.