[webkit-reviews] review granted: [Bug 113544] GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect : [Attachment 195675] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 28 16:40:57 PDT 2013


Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 113544: GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the
visible rect
https://bugs.webkit.org/show_bug.cgi?id=113544

Attachment 195675: Patch
https://bugs.webkit.org/attachment.cgi?id=195675&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195675&action=review


> Source/WebCore/ChangeLog:14
> +	   rect, it would need to make new tiles (which happens layer during a
flush).

Layers on the brain?

> Source/WebCore/rendering/RenderLayerCompositor.h:140
> +    void noteVisibleRectChanged();

Is "note" usually used for things that actually affect behavior? (I have no
idea).

didChangeVisibleRect?


More information about the webkit-reviews mailing list