[webkit-reviews] review granted: [Bug 113518] use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl : [Attachment 195641] updated patch: comment json in idl + tests all valid types in xmlhttprequest-responsetype-set-invalidtype

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted arno. <arno at renevier.net>'s
request for review:
Bug 113518: use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl
https://bugs.webkit.org/show_bug.cgi?id=113518

Attachment 195641: updated patch: comment json in idl + tests all valid types
in xmlhttprequest-responsetype-set-invalidtype
https://bugs.webkit.org/attachment.cgi?id=195641&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195641&action=review


Looks OK with nits.

> LayoutTests/ChangeLog:12
> +	   *
fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt:

Let's rename the test to xmlhttprequest-set-responsetype.html, as we're now
testing valid types as well.