[webkit-reviews] review granted: [Bug 113526] REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height. : [Attachment 195628] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 113526: REGRESSION(r143102): Ignore table cell's height attribute when
checking if containing block has auto height.
https://bugs.webkit.org/show_bug.cgi?id=113526

Attachment 195628: Patch
https://bugs.webkit.org/attachment.cgi?id=195628&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=195628&action=review


> Source/WebCore/ChangeLog:6
> +	   It matches Firefox behaviour.

More importantly it matches our behavior before r143102, right? Would be good
to mention that too. We don't really aspire to match Firefox exactly with all
the table edge cases.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:390
>  
> +    // Table cells violate what the CSS spec says to do with heights.
Basically we
> +    // don't care if the cell specified a height or not.

Is the comment correct? I thought CSS spec specifically left some of this open?