[webkit-reviews] review denied: [Bug 113198] Web Inspector: provide minimized mode. : [Attachment 195574] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 113198: Web Inspector: provide minimized mode.
https://bugs.webkit.org/show_bug.cgi?id=113198

Attachment 195574: Patch
https://bugs.webkit.org/attachment.cgi?id=195574&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195574&action=review


> Source/WebCore/inspector/front-end/DockController.js:107
> +	   if (this.isMinimized()) {

Still not fixed...

> Source/WebCore/inspector/front-end/Toolbar.js:398
> +	   this._bottomStatusBarContainer.appendChild(this._minimizedToolbar);

On the second thought, I don't see much sense in keeping this as a field -- we
have so many document.getElementById() calls in minimize(), which is the only
to use the field.