[webkit-reviews] review granted: [Bug 113427] Web Inspector: properly track main object for proto objects : [Attachment 195359] For trybots

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 28 08:04:28 PDT 2013


Yury Semikhatsky <yurys at chromium.org> has granted  review:
Bug 113427: Web Inspector: properly track main object for proto objects
https://bugs.webkit.org/show_bug.cgi?id=113427

Attachment 195359: For trybots
https://bugs.webkit.org/attachment.cgi?id=195359&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195359&action=review


>> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:343
>> +WebInspector.WatchExpressionTreeElement = function(property, mainObjectId)
> 
> Sorry, I don't see how Peter's feature is allowed to affect watch expressions
and such.

That's because the constructor is passed by pointer to
ObjectPropertiesSection.prototype.updateProperties


More information about the webkit-reviews mailing list