[webkit-reviews] review granted: [Bug 113357] Web Inspector: gather accessor property getter and setter under a single tree node : [Attachment 195447] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 113357: Web Inspector: gather accessor property getter and setter under a
single tree node
https://bugs.webkit.org/show_bug.cgi?id=113357

Attachment 195447: Patch
https://bugs.webkit.org/attachment.cgi?id=195447&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195447&action=review


Please attach screenshot.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:481
> +	   if (properties[i].value == null)

== -> ===

> Source/WebCore/inspector/front-end/RemoteObject.js:218
>		   if (property.get || property.set) {

style: no {} around one liners
I'd rather move this get/set logic into constructor.

> Source/WebCore/inspector/front-end/RemoteObject.js:453
> +    if (descriptor && descriptor.get) {

style: no {} around one liners

> Source/WebCore/inspector/front-end/RemoteObject.js:456
> +    if (descriptor && descriptor.set) {

style: no {} around one liners

> LayoutTests/inspector/debugger/properties-special.html:71
> +		   if (children[j].nameElement &&
children[j].nameElement.textContent === "__proto__") {

style: no {} around one liners

> LayoutTests/inspector/runtime/runtime-getProperties.html:63
> +    function convertPropertyValueForTest(propertyObj, fieldName)

propertyObj -> propertyObject