[webkit-reviews] review requested: [Bug 110835] [Chromium] Implement target-densityDpi viewport property emulation : [Attachment 195547] Move parsing code to ViewportArguments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 28 06:04:57 PDT 2013


Mikhail Naganov <mnaganov at chromium.org> has asked  for review:
Bug 110835: [Chromium] Implement target-densityDpi viewport property emulation
https://bugs.webkit.org/show_bug.cgi?id=110835

Attachment 195547: Move parsing code to ViewportArguments
https://bugs.webkit.org/attachment.cgi?id=195547&action=review

------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
Alexandre, thanks for your suggestions!

This is a refined version. I have moved the parsing code into
ViewportArguments. But parsing can't depend on a setting, because if the
setting will be enabled after the document has been parsed, that's too late,
and I don't want to trigger reparsing when the setting changes. So I have stuck
with a Chromium-only setting that controls, whether we are actually using the
provided value.


More information about the webkit-reviews mailing list