[webkit-reviews] review denied: [Bug 113327] Web Inspector: Exception in console on attempt to filter javascript messages. : [Attachment 195315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 28 05:28:21 PDT 2013


Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Zvorygin
<zvorygin at chromium.org>'s request for review:
Bug 113327: Web Inspector: Exception in console on attempt to filter javascript
messages.
https://bugs.webkit.org/show_bug.cgi?id=113327

Attachment 195315: Patch
https://bugs.webkit.org/attachment.cgi?id=195315&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195315&action=review


> LayoutTests/inspector/console/console-filter-test.html:17
> +	       log1(i + "topGroup"); // from console-filter-test.html

Please don't change the tests when doing refactorings - it is hard to spot the
regression and merge if necessary.


More information about the webkit-reviews mailing list