[webkit-reviews] review denied: [Bug 113306] Web Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor : [Attachment 195345] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 113306: Web Inspector: [Elements] Syntax-highlight the "Edit as HTML"
editor
https://bugs.webkit.org/show_bug.cgi?id=113306

Attachment 195345: Patch
https://bugs.webkit.org/attachment.cgi?id=195345&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195345&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:600
> +	       var event = document.createEvent("Event");

We never use generic event dispatching.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:-1542
> -	   this._editing = WebInspector.startEditing(this._htmlEditElement,
config);

I would still use this controller because it is useful and allows separation
between your logic and underlying editor.