[webkit-reviews] review denied: [Bug 112666] Web Inspector: [DataGrid] Persist column widths. : [Attachment 195490] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 112666: Web Inspector: [DataGrid] Persist column widths.
https://bugs.webkit.org/show_bug.cgi?id=112666

Attachment 195490: Patch
https://bugs.webkit.org/attachment.cgi?id=195490&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195490&action=review


> Source/WebCore/inspector/front-end/DOMStorageItemsView.js:184
> +	       {id: "key", title: WebInspector.UIString("Key"), editable: true,
weight: 30},

Why 30/70?

> Source/WebCore/inspector/front-end/DOMStorageItemsView.js:202
> +	   dataGrid.setName("keyValue");

Should be "DOMStorageItemsView"

> Source/WebCore/inspector/front-end/DataGrid.js:617
> +	   this.applyColumnWeights();

This looks like a change in behavior: you now apply column weights upon
setName.

> Source/WebCore/inspector/front-end/DataGrid.js:634
> +	  this._loadColumnWeights();

You want it to be reset upon each unhide (panel switch)? Does not sound right
to me.