[webkit-reviews] review denied: [Bug 113496] Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu. : [Attachment 195517] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 113496: Web Inspector: [Cookies] CookiesTable should integrate with
DataGrid context menu.
https://bugs.webkit.org/show_bug.cgi?id=113496

Attachment 195517: Patch
https://bugs.webkit.org/attachment.cgi?id=195517&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195517&action=review


> Source/WebCore/inspector/front-end/CookiesTable.js:281
> +    _refresh: function() {

{ on the next line.

> Source/WebCore/inspector/front-end/CookiesTable.js:282
> +	   this._refreshCallback && this._refreshCallback();

We never do this, please use explicit if.

> Source/WebCore/inspector/front-end/DataGrid.js:33
> + * @param {?function(!WebInspector.ContextMenu, WebInspector.DataGridNode)=}
contextMenuCallback

We don't use nullable optional fields. Please remove ? from here and above.