[webkit-reviews] review denied: [Bug 113239] Web Inspector: REGRESSION: Standalone image documents fail to return resource content : [Attachment 195530] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied pdeng6 <pan.deng at intel.com>'s
request for review:
Bug 113239: Web Inspector: REGRESSION: Standalone image documents fail to
return resource content
https://bugs.webkit.org/show_bug.cgi?id=113239

Attachment 195530: Patch
https://bugs.webkit.org/attachment.cgi?id=195530&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195530&action=review


> Source/WebCore/inspector/InspectorPageAgent.cpp:324
> +	   // Since MainResource may be actual image resource, use mime type to
determine the type for Inspector's view

This comment does not add much, consider removing.

> Source/WebCore/inspector/InspectorPageAgent.cpp:326
> +	   return
MIMETypeRegistry::isSupportedImageMIMEType(cachedResource.response().mimeType()
) ? InspectorPageAgent::ImageResource : InspectorPageAgent::DocumentResource;

Why not to check cached resource's type instead?

> Source/WebCore/inspector/InspectorResourceAgent.cpp:273
> +    else if (equalIgnoringFragmentIdentifier(response.url(), loader->url())
&& !loader->isCommitted() && type == InspectorPageAgent::OtherResource)

Why would other result in document?