[webkit-reviews] review requested: [Bug 113375] Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota. : [Attachment 195257] Patch

[bugzilla-daemon at webkit.org]

Eugene Klyuchnikov <eustas at chromium.org> has asked  for review:
Bug 113375: Web Inspector: [Settings] "previouslyViewedFiles" exceeds local
storage quota.
https://bugs.webkit.org/show_bug.cgi?id=113375

Attachment 195257: Patch
https://bugs.webkit.org/attachment.cgi?id=195257&action=review

------- Additional Comments from Eugene Klyuchnikov <eustas at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195257&action=review


>> Source/WebCore/inspector/front-end/TabbedEditorContainer.js:601
>> +		if (serializedHistory.length ===
WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount)
> 
> What if it already was larger than maximum?

serializedHistory is initially clear and we add at most one item per loop.

So this is possible only in if maximalPreviouslyViewedFilesCount <= 0.