[webkit-reviews] review granted: [Bug 113463] [WebKit2] Need SPI to determine whether a plug-in is blocked : [Attachment 195470] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 113463: [WebKit2] Need SPI to determine whether a plug-in is blocked
https://bugs.webkit.org/show_bug.cgi?id=113463

Attachment 195470: Patch
https://bugs.webkit.org/attachment.cgi?id=195470&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195470&action=review


> Tools/ChangeLog:18
> +2013-03-27  Gustavo Noronha Silva  <gns at gnome.org>
> +
> +	   [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with
custom libsoup
> +	   https://bugs.webkit.org/show_bug.cgi?id=113203
> +
> +	   Reviewed by Philippe Normand.
> +
> +	   We build our libsoup without GNOME support. gst-plugins-good does
separate
> +	   pkg-config checks for libsoup-gnome and libsoup, causing the build
to use
> +	   libsoup-gnome from the system and soup from the jhbuild prefix. This
may lead to
> +	   build failures as the headers of those diverge. We do not use
souphttpsrc, so
> +	   disable it when building gst-plugins-good.
> +
> +	   * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
> +
>  2013-03-27  Ryosuke Niwa  <rniwa at webkit.org>
>  
>	   Build fix after r146852. Please another reference to the Lion leaks
builder.

Wat

> Tools/gtk/jhbuild.modules:266
>      <branch repo="gstreamer" module="gst-plugins-base"
checkoutdir="gst-plugins-base" tag="1.0.4"/>
>    </autotools>
>  
> -  <autotools id="gst-plugins-good" autogenargs="--disable-examples">
> +  <autotools id="gst-plugins-good" autogenargs="--disable-examples
--disable-soup">
>      <dependencies>
>	 <dep package="gst-plugins-base"/>
>      </dependencies>

I don't think you meant to include this.